Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Assertion fails when errorPageBuilder is used #91

Closed
ebati opened this issue Oct 13, 2021 · 2 comments
Closed

Assertion fails when errorPageBuilder is used #91

ebati opened this issue Oct 13, 2021 · 2 comments
Labels
bug Something isn't working fix awaiting confirmation

Comments

@ebati
Copy link

ebati commented Oct 13, 2021

I expect errorPageBuilder should be called after no route is found for a location but assertion here fails after Exception: no routes for location: /asd is printed on debug logs. I think this line causes the issue, here path is set but fullpath is empty.
@csells csells added the bug Something isn't working label Oct 14, 2021
@csells
Copy link
Owner

csells commented Oct 17, 2021 •
edited
Loading

fixed in v2.1.2. @ebati can you please verify?

@ebati
Copy link
Author

ebati commented Oct 18, 2021

Changes fix my issue. Thank you very much for fast fix and the new version 😃

@ebati ebati closed this as completed Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working fix awaiting confirmation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csells @ebati