Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Milestones per task causes incorrect group height #61

Closed
rickc1588 opened this issue Aug 10, 2023 · 3 comments
Closed

Multiple Milestones per task causes incorrect group height #61

rickc1588 opened this issue Aug 10, 2023 · 3 comments

Comments

@rickc1588
Copy link

If you have multiple milestones on one task, the group height increases with the total number of milestones, which makes it too tall. You only need to increase the height once per task with a milestone.

I hacked in this in group.py, which seems to fix the issue

milestone_count = 0
for task in self.tasks:
milestone_count += 1 #len(task.milestones) only need to increase height once per milestone
if len(task.milestones) == 0:
for parallel_task in task.tasks:
milestone_count += 1 #len(parallel_task.milestones)
break ### We only need to know whether there milestone exists in the parallel tasks

@csgoh
Copy link
Owner

csgoh commented Aug 16, 2023

Hi, can you provide your code sample that I can use to recreate the issue?

@csgoh
Copy link
Owner

csgoh commented Sep 10, 2023

This has been resolved in v1.3.1

@rickc1588
Copy link
Author

Tested it and it is fixed.
Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants