-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manager container uses latest tag resulting in possible CRD mismatch #600
Comments
Are these the errors you saw? Using
Deployed using:
|
@rich0 - as you suggest doing an override of
|
@rich0 if we are using the latest image in the yamls in the released version (this is wrong) we will take care of this in the next release to ensure that we will have only released tags for the images. @Rakshith-R can you please check this one? |
How soon can we get a new release to fix this? Seems like all users of v0.8.0 are currently broken unless a manual workaround is applied. |
@travisn this looks like a doc problem on how to pull the yamls, I will update the doc in sometime |
Thanks, I see now it was a doc problem and is fixed in the Rook repo with rook/rook#14408, but it still seems a bug that the download link has different content than the tagged yaml. |
Yes this need some extra steps to commit changes after tagging, will revisit this later to fix it. |
we can use something like https://github.com/stefanzweifel/git-auto-commit-action to push changes to the tag during the release phase from CI. @nixpanic @Rakshith-R any thoughts? |
Or should we just add install instructions in release notes(which have release download urls) and point to that from all other places to install released manifests ?
|
I do not think that is needed. The tagged v0.8.0 release uses Users that want to install from the Am I missing something? |
|
Users should be encouraged to download/fetch a tag. This repository does not even have branches for releases? |
Ah, maybe I understand now.
In order to fix that, the release job should indeed push the generated artifacts into git. Overwriting (force re-push) the initially created The CI job should probably have a force-push-to-tag after creating the manifests here (or maybe as one of the 1st steps): kubernetes-csi-addons/.github/workflows/tag-release.yaml Lines 134 to 136 in 542ecb8
|
For the v0.9.0 release I created a commit with the (hopefully) right version in the files, and built the release artifacts after that. When someone checks out the v0.9.0 tag, they should have the |
I am running v0.8.0 of csi-addons and began getting crash loops with error messages referencing a missing VolumeGroupReplication CRD (and other related ones). Looking at the source these CRDs are present in the development branch but not the v0.8 tag.
Looking at setup-controller.yaml there is a :latest tag on the manager container. Changing this to v0.8.0 appears to resolve this issue, and if the manager is going to use the bundled CRDs it should probably be version tagged to ensure the two are consistent.
The text was updated successfully, but these errors were encountered: