You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you very much for creating and maintaining this library.
Looking at the source code of RuleFit, I find that the sample_fract parameter/attribute is unused. It is set in the constructor and then never used again. I also searched through the source files and could not find a meaningful use of sample_fract . It is set in other classes such as StableLinear and FPLasso but not used there either. Also i checked against TransformerMixin and ClassifierMixin they also don't seem to use the sample_fract parameter.
It seems there is an sample_frac_ in line 37 in extract.py
Dear maintainers of imodel,
Thank you very much for creating and maintaining this library.
Looking at the source code of RuleFit, I find that the
sample_fract
parameter/attribute is unused. It is set in the constructor and then never used again. I also searched through the source files and could not find a meaningful use ofsample_fract
. It is set in other classes such asStableLinear
andFPLasso
but not used there either. Also i checked againstTransformerMixin
andClassifierMixin
they also don't seem to use thesample_fract
parameter.It seems there is an
sample_frac_
in line 37 in extract.pyimodels/imodels/util/extract.py
Lines 36 to 39 in 6efaa90
But it seems to be unaffected by
RuleFit.sample_fract
.Is this intended behavior? Or is it planned, that this parameter is used in the future/ was used in the past?
Thank you very much for clarifying
The text was updated successfully, but these errors were encountered: