Upgrade all esm ready packages #1029
Conversation
rollup.config.js
Outdated
| @@ -86,7 +88,7 @@ export default [ | |||
| plugins: [ | |||
| nodeResolve(), | |||
| babel(getBabelOptions({useESModules: true})), | |||
| commonjs(commonjsOptions), | |||
| reactPkg && commonjs(commonjsOptions), | |||
There was a problem hiding this comment.
To make sure we will never ever add another commonjs package in our dependencies.
There was a problem hiding this comment.
but why this conditional and not for everything?
There was a problem hiding this comment.
Because we dropped commonjs for everything except react based packages.
There was a problem hiding this comment.
it just seems like we are addng there another list to maintain
There was a problem hiding this comment.
I don't think it will be changed before react will accept esm.
|
@AleshaOleg is looking into css-vendor problem |
yarn.lock
Outdated
| @@ -5,21 +5,18 @@ | |||
| "@babel/code-frame@^7.0.0": | |||
| version "7.0.0" | |||
| resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0.tgz#06e2ab19bdb535385559aabb5ba59729482800f8" | |||
| integrity sha512-OfC2uemaknXr87bdLUkWog7nYuliM9Ij5HUcajsVcMCpQrcLmtxRbVFTIqmcSkSeYRBFBRxs2FiUqFJDLdiebA== | |||
There was a problem hiding this comment.
@kof Update your yarn please
There was a problem hiding this comment.
damn, what happened here? we have 1.9 in engines
There was a problem hiding this comment.
Yes, I have 1.13. integrity hash was added after 1.9
There was a problem hiding this comment.
strange, upgraded, but it doesn't add themm back
There was a problem hiding this comment.
Revert yarn.lock and run yarn again
|
Tests are passed, but red cross still there. Who knows what's wrong? |
|
there is another issue https://travis-ci.org/cssinjs/jss/builds/491780740#L612 with flow, it can't find react-jss dependency, I have the same locally |
|
Ah, ok. I had it too today. I did |
|
for me run build doesn't fix this, neither it does for the ci |
|
Will also take a look at the issue |
| @@ -48,6 +48,11 @@ const getBabelOptions = ({useESModules}) => ({ | |||
| }) | |||
|
|
|||
| const commonjsOptions = { | |||
| include: [ | |||
| /\/node_modules\/react\//, | |||
There was a problem hiding this comment.
This here creates the issue with flow.
There was a problem hiding this comment.
I get it. We use ancient rollup version which silently swallowed commonjs errors without emitting files.
There was a problem hiding this comment.
Upgrading it in separate branch
There was a problem hiding this comment.
So upgrading to rollup v1 would solve the issue?
There was a problem hiding this comment.
It will show the real error which is swallowed now.
There was a problem hiding this comment.
Seems like the error was in missed react-display-name package which is a transitive dependency of theming.
In this diff I upgraded - hyphenate-style-name - css-initials - css-vendor which were converted to esm. This means, that all jss and all plugins may be consumed by unpkg with module flag like https://unpkg.com/jss-preset-default?module We probably may get rid from unpkg prop in favour of `?module` flag for non react packages.
This reverts commit ec623f7.
TrySound
force-pushed
the
full-esm-support
branch
from
0ebcdab to
7c2d7c2
Compare
|
Looks good now 👍 |
* Upgrade all esm ready packages In this diff I upgraded - hyphenate-style-name - css-initials - css-vendor which were converted to esm. This means, that all jss and all plugins may be consumed by unpkg with module flag like https://unpkg.com/jss-preset-default?module We probably may get rid from unpkg prop in favour of `?module` flag for non react packages. * Replace react pkgs list with commonjs packages list * upgrade css-vendor * Revert "upgrade css-vendor" This reverts commit ec623f7. * upgrade css-vendor * set yarn 1.13 in engines
In this diff I upgraded
which were converted to esm.
This means, that all jss and all plugins may be consumed by unpkg with
module flag like https://unpkg.com/jss-preset-default?module
We probably may get rid from unpkg prop in favour of
?moduleflag fornon react packages.