Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript support for createUseStyles theme #1294

Merged
merged 1 commit into from
Mar 15, 2020
Merged

typescript support for createUseStyles theme #1294

merged 1 commit into from
Mar 15, 2020

Conversation

ntduan
Copy link
Contributor

@ntduan ntduan commented Mar 5, 2020

Corresponding issue (if exists):

What would you like to add/fix?

Let createUseStyles have the default theme type. Like this:
image

Just add this to your project to work

declare module 'react-jss' {
  interface DefaultTheme {
    ...
  }
}

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@ntduan ntduan requested a review from HenriBeck as a code owner March 5, 2020 05:25
@kof kof added the typescript label Mar 5, 2020
@ntduan
Copy link
Contributor Author

ntduan commented Mar 11, 2020

Any progress or problems?

@kof
Copy link
Member

kof commented Mar 15, 2020

I am no expert in TS, but since no one is who is actively helping I am gonna merge this and hope you tested it.

@kof kof merged commit 05585ea into cssinjs:master Mar 15, 2020
@kof
Copy link
Member

kof commented Mar 15, 2020

Thanks

@kof
Copy link
Member

kof commented Mar 15, 2020

released in 10.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants