Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flow-bin to 0.131.0 and migrate types #1382

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Upgrade flow-bin to 0.131.0 and migrate types #1382

merged 5 commits into from
Aug 14, 2020

Conversation

kof
Copy link
Member

@kof kof commented Aug 12, 2020

Todo

  • Upgrade theming package
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/theming/src/create-with-theme.js:23:18

Cannot spread props because Flow cannot determine a type for props [1]. object type [2] is
inexact, so it may contain ref with a type that conflicts with ref's definition in props [1].
Try making object type [2] exact. [cannot-spread-inexact]

     node_modules/theming/src/create-with-theme.js
      20│             '[theming] Please use withTheme only with the ThemeProvider'
      21│           );
      22│
 [1]  23│           return <Component theme={theme} ref={ref} {...props} />;
      24│         }}
      25│       </context.Consumer>
      26│     ));

     /private/tmp/flow/flowlib_36a9420e/react.js
 [2] 159│ declare type React$ComponentType<-Config> = React$AbstractComponent<Config, mixed>;

@kof kof requested a review from HenriBeck as a code owner August 12, 2020 12:47
@kof kof requested a review from TrySound August 12, 2020 14:38
@kof
Copy link
Member Author

kof commented Aug 14, 2020

Finally finished upgrading dependencies, thanks @TrySound for the CR!

@kof kof merged commit 9a3ae41 into master Aug 14, 2020
@kof
Copy link
Member Author

kof commented Aug 14, 2020

released in 10.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants