fix: jssStyle type #1423
Merged
fix: jssStyle type #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the actual error compiler was reporting? This fix seems fishy, need some ts experts to confirm cc @moshest |
|
the bug is where intellisense no suggestions can't suggest CSS Properties. |
|
Because we tell them k is CSS properties or string, which means any string. |
|
oh I see, that makes sense |
|
Why we remove there the |
typescript can't work with [K in keyof NormalCssProperties | string]
Hi, You are right, that is my mistake, I fix that. |
kof
reviewed
Nov 15, 2020
|
@kof please review the last commit |
|
lgtm |
|
merged, thanks |
|
Could you please publish master? |
|
Please publish |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript can't work with [K in keyof NormalCssProperties | string]
Corresponding issue (if exists):
What would you like to add/fix?
type definition
Todo