Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomly (?) failing test #1275

Closed
gabemery opened this issue Jul 11, 2024 · 1 comment · Fixed by #1276
Closed

Randomly (?) failing test #1275

gabemery opened this issue Jul 11, 2024 · 1 comment · Fixed by #1276
Assignees
@chaimain @deborahDOR
Labels
bug Something isn't working

Comments

@gabemery
Copy link
Collaborator

The following test : lstchain/tools/tests/test_tools.py::test_add_scale_true_energy_in_irfs
Failed once during CI of an unrelated PR : https://github.com/cta-observatory/cta-lstchain/actions/runs/9890700906/job/27319513170?pr=1274

Re-launching the test worked so it may be a randomly occurring issue.
@gabemery gabemery added the bug Something isn't working label Jul 11, 2024
@chaimain
Copy link
Contributor

That is random indeed...
@deborahDOR Can you check with the test MC file being used, the exact values of the shifted Energy Migration matrix? Maybe you can try to make a large shift by using scale_true_energy=1.3 or something similar, so as to be certain to avoid such random test fails?

@deborahDOR deborahDOR linked a pull request Jul 11, 2024 that will close this issue
Fix a small test to avoid random fails #1276
Merged
@chaimain chaimain mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaimain chaimain

@deborahDOR deborahDOR

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a small test to avoid random fails cta-observatory/cta-lstchain
3 participants
@gabemery @chaimain @deborahDOR