Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low level calibration code not compatible with missing modules #182

Closed
FrancaCassol opened this issue Oct 2, 2019 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@FrancaCassol
Copy link
Collaborator

Hi,

it seems that the present low level calibrator is not compatible with missing modules (as in the data since a week). In the loops over modules one should not use the index over the global number of modules "range(0, n_modules)" but the number of the modules stored in event.lst.tel[1].svc.module_ids.

@pawel21 could you take care of the correction? (otherwise I can try to do it)
This is necessary to get low level calibration files for the present data.

@pawel21
Copy link
Collaborator

pawel21 commented Oct 2, 2019

I have checked my code using data from Run 1413 (with 264 modules) and I have discovered that code should work for less than 265 modules.
I have already implemented (in r0.py) to use correct number of modules (n_modules = event.lst.tel[self.tel_id].svc.num_modules).

What kind of problem did you find?

@pawel21
Copy link
Collaborator

pawel21 commented Oct 3, 2019

I found one possible scenario, when We can have problem with low level calib.
This can happen when the number of module using to create pedestal file don't agree with number of modules from data run.

I have created PR #183

@rlopezcoto rlopezcoto added the bug Something isn't working label Oct 17, 2019
@rlopezcoto
Copy link
Contributor

Solved in #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants