Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x_max to h_max conversion in AtmosphereDensityProfile #2390

Closed
kosack opened this issue Aug 31, 2023 · 5 comments
Closed

x_max to h_max conversion in AtmosphereDensityProfile #2390

kosack opened this issue Aug 31, 2023 · 5 comments
Assignees

Comments

@kosack
Copy link
Contributor

kosack commented Aug 31, 2023

Please describe the use case that requires this feature.

Currently we have atmprof.line_of_sight_integral(h, zenith) that converts h (distance in m) to x (slant depth in g cm-2). For the ImPACT analysis, we need the inverse transform as well.

Describe the solution you'd like

Implement derivative() functions for all AtmosphereDensityProfiles, similar to the existing integral() and provide a top-level function to do the line_of_sight_derivative()

needed for #2305

@kosack kosack self-assigned this Aug 31, 2023
@maxnoe
Copy link
Member

maxnoe commented Aug 31, 2023

Is it really the derivative we need?

The inverse function of an integral is not the derivative...

@kosack
Copy link
Contributor Author

kosack commented Aug 31, 2023

true, not the best name

@kosack
Copy link
Contributor Author

kosack commented Aug 31, 2023

Could just rename both of them distance_to_slant_depth() and slant_depth_to_distance()

@kosack
Copy link
Contributor Author

kosack commented Sep 5, 2023

Also, we should consider renaming h_max to d_max or shower_max_distance or something, to be clear that it is not the height A.S.L., but really the distance to the shower max along the shower direction. That way it's clear that this and x_max are the same measure but expressed in different units.

@maxnoe
Copy link
Member

maxnoe commented Jul 15, 2024

This was fixed: #2422

@maxnoe maxnoe closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants