Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EBL data from Dominguez et al. 2011 #5

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Add EBL data from Dominguez et al. 2011 #5

merged 11 commits into from
Sep 20, 2024

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Mar 4, 2024

closes #6

@HealthyPear HealthyPear requested review from jsitarek and removed request for jsitarek September 19, 2024 11:57
@HealthyPear
Copy link
Member Author

@jsitarek would you like to review this? It comes from your old scripts linked here under "MAGIC PROPOSAL TOOLS / Source Detectability"

src/iact_estimator/io.py Outdated Show resolved Hide resolved
Copy link

@jsitarek jsitarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one typo, but since you are either way using gammapy, why not taking the EBL models from it?

@HealthyPear
Copy link
Member Author

looks good, just one typo, but since you are either way using gammapy, why not taking the EBL models from it?

yes I am going to use gammapy in the end for most of the estimations, this PR is a bit legacy: I'd like to make sure that the package replicates the old scripts first before the big refactoring.

@HealthyPear HealthyPear merged commit 1382735 into main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing EBL data
2 participants