Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

ensure path casing for debug documents #171

Closed
ctaggart opened this issue Mar 15, 2017 · 2 comments
Closed

ensure path casing for debug documents #171

ctaggart opened this issue Mar 15, 2017 · 2 comments

Comments

@ctaggart
Copy link
Owner

While enabling source link for Rx.NET #167, we discovered that calling the PowerShell build scripts with the wrong case resulted in debug documents with wrong case for the paths too. My guess is that the full path msbuild call is resulting in a compiler property. To make enabling source link easier, we should investigate and see if it is possible to override with a Path.GetFullPath or something similar.

@ctaggart ctaggart changed the title help ensure path casing for debug documents ensure path casing for debug documents Mar 15, 2017
@ctaggart
Copy link
Owner Author

ctaggart commented Mar 23, 2017

The solution for this one should hopefully be pretty easy. In the SourceLink.Create.GitHub.targets, we just need to change it to pass in both @(Compile) and @(EmbeddedFiles), then also pass back out @(Compile) with Path.GetFullPath called called for each item.

@ctaggart
Copy link
Owner Author

ctaggart commented May 3, 2017

This affects SourceLink.Create.GitHub and not SourceLink.Create.CommandLine. Rx.NET has switched to Rx.NET. I'm going to close this until it is surfaces again.

@ctaggart ctaggart closed this as completed May 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant