fix: handling of AssertionResult.failureDetails #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append AssertionResult.failureDetails to CtrfTest.trace when setting .trace and .message attributes from the AssertionResult to prevent overwriting .trace when AssertionResult.failureDetails is set.
an-ky
force-pushed
the
fix/handle-failureDetails
branch
from
3508c94 to
ca7b9f3
Compare
an-ky
commented
Jun 10, 2024
src/generate-report.ts
Outdated
| @@ -184,7 +185,7 @@ class GenerateCtrfReport implements Reporter { | |||
| } | |||
|
|
|||
| if (testResult.failureDetails !== undefined) { | |||
| failureDetails.trace = testResult.failureMessages.join('\r\n') | |||
| failureDetails.trace = failureDetails.trace?.concat('\n\n', testResult.failureDetails.join('\n')) | |||
There was a problem hiding this comment.
Originally, failureMessage was assigned to trace. Was this intended?
And is it possible to just join failureDetails which is Array<unknown>. I don't know how to handle this properly
Ma11hewThomas
approved these changes
Jun 11, 2024
|
Thanks for your contribution, published v0.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append AssertionResult.failureDetails to CtrfTest.trace when setting .trace and .message attributes from the AssertionResult to prevent overwriting .trace when AssertionResult.failureDetails is set.