Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add csv data used to test notebooks. But where? #9

Open
ctwardy opened this issue Jan 14, 2021 · 0 comments
Open

Add csv data used to test notebooks. But where? #9

ctwardy opened this issue Jan 14, 2021 · 0 comments
Assignees
@ctwardy

Comments

@ctwardy
Copy link
Owner

ctwardy commented Jan 14, 2021 •
edited
Loading

Nbdev's CI tests the notebooks in nbs/. Some of these look for data in its canonical place (see image), but of course we don't check the data/ folder into the repo, or it would clobber whatever real setup the user has.

image

What to do?

Probably put this file into the nbs folder, or nbs/data, or a test folder.

Thoughts? @cmorris-jacobs @dmackenzie-1 ?
@ctwardy ctwardy self-assigned this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctwardy ctwardy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctwardy