Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): prop to display menu checkbox #151

Merged
merged 6 commits into from
Jul 7, 2022
Merged

fix(menu): prop to display menu checkbox #151

merged 6 commits into from
Jul 7, 2022

Conversation

nikolaykost
Copy link
Contributor

@nikolaykost nikolaykost commented Jul 4, 2022 •
edited
Loading

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 2d5ad4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikolaykost nikolaykost requested a review from tenphi July 4, 2022 19:29
@nikolaykost
Merge remote-tracking branch 'origin/main' into fix-menu-checkbox
679fe97 
# Conflicts:
#	src/components/pickers/Menu/Menu.tsx
#	src/components/pickers/Menu/MenuSection.tsx
@nikolaykost
fix: after merge
f5b3bdb
@nikolaykost nikolaykost temporarily deployed to Docs staging July 4, 2022 19:44 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited
Loading

📦 NPM canary release

Deployed canary version 0.0.0-canary-ed20a8e.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited
Loading

🏋️ Size limit report

Name Size Passed?
All 218.11 KB (+0.05% 🔺) Yes 🎉
Tree shaking (just a Button) 31.66 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited
Loading

🏗 Docs are successfully deployed!

👀 Preview: https://62c6a49fe2cdb566b1da9fd5--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited
Loading

🧪 Storybook is successfully deployed!

@nikolaykost nikolaykost temporarily deployed to Docs staging July 4, 2022 19:46 Inactive
@tenphi tenphi temporarily deployed to Docs staging July 7, 2022 08:51 Inactive
@tenphi tenphi temporarily deployed to Docs staging July 7, 2022 09:15 Inactive
@tenphi
Copy link
Member

tenphi commented Jul 7, 2022

selectionType is not a good name for changing icons.
Checkbox inside the Circle is not a Radio icon in any way.
Very bad customization for icons. (will do it later)

I fixed that myself.

@nikolaykost nikolaykost merged commit e3eaeba into main Jul 7, 2022
@nikolaykost nikolaykost deleted the fix-menu-checkbox branch July 7, 2022 11:08
@github-actions github-actions bot mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenphi tenphi tenphi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikolaykost @tenphi