Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset.style): font-family fallback #162

Merged
merged 10 commits into from
Aug 10, 2022
Merged

fix(preset.style): font-family fallback #162

merged 10 commits into from
Aug 10, 2022

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Jul 29, 2022

Describe changes

Fix font family fallback issues.

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022

🦋 Changeset detected

Latest commit: 0b7b936

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

🏗 Docs are successfully deployed!

👀 Preview: https://62f3beabf9296c57e043bae5--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

📦 NPM canary release

Deployed canary version 0.0.0-canary-f14c197.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

🏋️ Size limit report

Name Size Passed?
All 140.93 KB (+0.06% 🔺) Yes 🎉
Tree shaking (just a Button) 31.89 KB (+0.23% 🔺) Yes 🎉

Click here if you want to find out what is changed in this build

.changeset/poor-rules-knock.md Outdated Show resolved Hide resolved
src/tasty/styles/preset.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@MrFlashAccount MrFlashAccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants