Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify if Notification should be removed on unmount #169

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Aug 8, 2022

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: 46225dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

🏗 Docs are successfully deployed!

👀 Preview: https://62fa266a1005162db32f4e6c--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

📦 NPM canary release

Deployed canary version 0.0.0-canary-dd5b832.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

🏋️ Size limit report

Name Size Passed?
All 141.05 KB (+0.01% 🔺) Yes 🎉
Tree shaking (just a Button) 32.03 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@MrFlashAccount MrFlashAccount merged commit fe67fcc into main Aug 15, 2022
@MrFlashAccount MrFlashAccount deleted the bugfix/add-control-over-unmount-in-notifications branch August 15, 2022 11:09
@github-actions github-actions bot mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants