feat: originalSql external pre-aggregations support

cube-js · Sep 8, 2019 · 0db2282 · 0db2282
1 parent aa860e4
commit 0db2282
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/cubejs-schema-compiler/adapter/BaseQuery.js b/packages/cubejs-schema-compiler/adapter/BaseQuery.js
@@ -177,14 +177,14 @@ class BaseQuery {
       if (preAggregationForQuery && preAggregationForQuery.preAggregation.external) {
         return true;
       }
+      return R.all((p) => p.external, this.preAggregations.preAggregationsDescription());
     }
     return false;
   }
 
   buildSqlAndParams() {
     if (!this.options.preAggregationQuery && this.externalQueryClass) {
-      const preAggregationForQuery = this.preAggregations.findPreAggregationForQuery();
-      if (preAggregationForQuery && preAggregationForQuery.preAggregation.external) {
+      if (this.externalPreAggregationQuery()) { // TODO performance
         const ExternalQuery = this.externalQueryClass;
         return new ExternalQuery(this.compilers, {
           ...this.options,