feat: More logging info for Orphaned Queries debugging

cube-js · Jul 20, 2020 · 99bf957 · 99bf957
1 parent 861db10
commit 99bf957
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/packages/cubejs-query-orchestrator/orchestrator/QueryQueue.js b/packages/cubejs-query-orchestrator/orchestrator/QueryQueue.js
@@ -318,9 +318,26 @@ class QueryQueue {
           processingLockAcquired,
           query,
           insertedCount,
-          activeKeys
+          activeKeys,
+          activated,
+          queryExists: !!query
         });
-        await redisClient.freeProcessingLock(queryKey, processingId, activated);
+        const currentProcessingId = await redisClient.freeProcessingLock(queryKey, processingId, activated);
+        if (currentProcessingId) {
+          this.logger('Skipping free processing lock', {
+            processingId,
+            currentProcessingId,
+            queryKey: query && query.queryKey || queryKey,
+            requestId: query && query.requestId,
+            queuePrefix: this.redisQueuePrefix,
+            processingLockAcquired,
+            query,
+            insertedCount,
+            activeKeys,
+            activated,
+            queryExists: !!query
+          });
+        }
       }
     } catch (e) {
       this.logger('Queue storage error', {

diff --git a/packages/cubejs-query-orchestrator/orchestrator/RedisQueueDriver.js b/packages/cubejs-query-orchestrator/orchestrator/RedisQueueDriver.js
@@ -160,6 +160,9 @@ class RedisQueueDriverConnection {
         }
         await removeCommand
           .execAsync();
+        return null;
+      } else {
+        return currentProcessId;
       }
     } finally {
       await this.redisClient.unwatchAsync();