Skip to content

Commit

Permalink
fix: BigQuery external rollup compatibility: use __ separator for m…
Browse files Browse the repository at this point in the history
…ember aliases. Fix missed override.
  • Loading branch information
paveltiunov committed Jul 31, 2019
1 parent 8f4bc93 commit c1eb113
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/cubejs-schema-compiler/adapter/BigqueryQuery.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ class BigqueryQuery extends BaseQuery {
return new BigqueryFilter(this, filter);
}

aliasName(name) {
return super.aliasName(name).replace(/\./g, '_');
}

dateSeriesSql(timeDimension) {
return `${timeDimension.dateSeriesAliasName()} AS (${this.seriesSql(timeDimension)})`;
}
Expand Down

0 comments on commit c1eb113

Please sign in to comment.