Skip to content

Commit

Permalink
fix: typings export (#373) Thanks to @lvauvillier!
Browse files Browse the repository at this point in the history
* fix: typings export

* fix: wrong dateRange type
  • Loading branch information
lvauvillier authored Feb 13, 2020
1 parent 45c7b83 commit f4ea839
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
3 changes: 1 addition & 2 deletions packages/cubejs-bigquery-driver/driver/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { BigQueryOptions } from "@google-cloud/bigquery";

declare module "@cubejs-backend/bigquery-driver" {
class BigQueryDriver {
export default class BigQueryDriver {
constructor(options?: BigQueryOptions);
}
export = BigQueryDriver;
}
3 changes: 1 addition & 2 deletions packages/cubejs-postgres-driver/driver/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { PoolConfig } from "pg";

declare module "@cubejs-backend/postgres-driver" {
class PostgresDriver {
export default class PostgresDriver {
constructor(options?: PoolConfig);
}
export = PostgresDriver;
}
1 change: 1 addition & 0 deletions packages/cubejs-postgres-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"@types/pg": "^7.14.1",
"eslint": "^5.16.0",
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.16.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-server-core/core/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ declare module "@cubejs-backend/server-core" {

export interface QueryTimeDimension {
dimension: string;
dateRange?: string[];
dateRange?: string[] | string;
granularity?: QueryTimeDimensionGranularity;
}

Expand Down
3 changes: 1 addition & 2 deletions packages/cubejs-sqlite-driver/driver/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ declare module "@cubejs-backend/sqlite-driver" {
database: string;
}

class SqliteDriver {
export default class SqliteDriver {
constructor(options?: SqliteOptions);
}
export = SqliteDriver;
}

0 comments on commit f4ea839

Please sign in to comment.