Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VueJs Client, limit not working #188

Closed
agustindiazg opened this issue Aug 22, 2019 · 1 comment · Fixed by #194
Closed

VueJs Client, limit not working #188

agustindiazg opened this issue Aug 22, 2019 · 1 comment · Fixed by #194

Comments

@agustindiazg
Copy link

Describe the bug
When you try to perform a Limit on the query, que query builder, will not send the limit set to the backend. The vue client is not looking for that parameter to sent.
@paveltiunov
Copy link
Member

@AgussDiaz28 Hey Agustin! Thanks for posting this! As I see there's TODO for it: https://github.com/cube-js/cube.js/blob/master/packages/cubejs-vue/src/QueryBuilder.js#L150

@TCBroad TCBroad mentioned this issue Aug 30, 2019
Merged
4 tasks
paveltiunov pushed a commit that referenced this issue Sep 5, 2019
@TCBroad @paveltiunov
feat: vue limit, offset and measure filters support (#194)
33f365a 
* Fixed issue with filters not using 'members' and only matching against dimensions
- Added support for limit and offset

* Updated documentation for added features

* Fixed existing tests, added tests for new features

* Added old 'dimension' property back in to filters

Fixes #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing features to vue package TCBroad/cube.js
2 participants
@paveltiunov @agustindiazg