Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@cubejs-client/core] Types for ResultSet are too strict #350

Closed
hassankhan opened this issue Jan 15, 2020 · 0 comments · Fixed by #358
Closed

[@cubejs-client/core] Types for ResultSet are too strict #350

hassankhan opened this issue Jan 15, 2020 · 0 comments · Fixed by #358

Comments

@hassankhan
Copy link
Contributor

hassankhan commented Jan 15, 2020 •
edited
Loading

Describe the bug
The pivotConfig parameter should be optional

To Reproduce
Steps to reproduce the behavior:

  1. Use Typescript
  2. Try compiling resultSet.tablePivot()
  3. See error

Expected behavior
The compiler should not throw an error saying pivotConfig is a required object.

Screenshots
Screen Shot 2020-01-15 at 22 21 57

Version:
0.13.9
hassankhan added a commit to EndemolShineGroup/cube.js that referenced this issue Jan 20, 2020
@hassankhan
fix(@cubejs-client/core): improve types
26087c6 
Fixes cube-js#350
@hassankhan hassankhan mentioned this issue Jan 20, 2020
Merged
4 tasks
hassankhan added a commit to EndemolShineGroup/cube.js that referenced this issue Jan 20, 2020
@hassankhan
fix(@cubejs-client/core): improve types
92e2ea8 
Fixes cube-js#350
hassankhan added a commit to EndemolShineGroup/cube.js that referenced this issue Jan 21, 2020
@hassankhan
fix(@cubejs-client/core): improve types
7c0748a 
Fixes cube-js#350
hassankhan added a commit to EndemolShineGroup/cube.js that referenced this issue Jan 22, 2020
@hassankhan
fix(@cubejs-client/core): improve types
55edf85 
Fixes cube-js#350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@cubejs-client/core): improve types EndemolShineGroup/cube.js
1 participant
@hassankhan