Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel step names cannot contain spaces #359

Closed
hassankhan opened this issue Jan 27, 2020 · 1 comment
Closed

Funnel step names cannot contain spaces #359

hassankhan opened this issue Jan 27, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@hassankhan
Copy link
Contributor

hassankhan commented Jan 27, 2020

Describe the bug
When defining steps for a funnel as described in the docs, a step name with spaces in it cannot be used. For example, given a step name 'Awaiting Approval', the generated SQL for the step is as follows:

LEFT JOIN (
  select
    user_id user_id,
    created_at t
  from
     <STEP_QUERY>
) awaiting _approval_events ON negotiation_events.user_id = awaiting _approval_events.user_id
AND awaiting _approval_events.t >= negotiation_events.t

To Reproduce
Steps to reproduce the behavior:

  1. Create a new funnel
  2. Add a new step to the funnel with a name that has a space character
  3. Attempt to run any query against the funnel cube
  4. Get error Error: syntax error at or near "."

Expected behavior
I expected it to generate the SQL correctly i.e. awaiting _approval_events should be awaiting_approval_events

Version:
v0.15.0

@hassankhan hassankhan changed the title Funnel step names cannot contain space Funnel step names cannot contain spaces Jan 27, 2020
@paveltiunov
Copy link
Member

@hassankhan Hey Hassan! Thanks for posting this! Yep. It's known issue we need to fix.

@paveltiunov paveltiunov added the bug Something isn't working label Jan 27, 2020
@paveltiunov paveltiunov added this to the v0.17.2 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants