Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to install core-js@2 for a sample #418

Closed
chengtie opened this issue Feb 19, 2020 · 5 comments
Closed

Need to install core-js@2 for a sample #418

chengtie opened this issue Feb 19, 2020 · 5 comments
Milestone

Comments

@chengtie
Copy link

chengtie commented Feb 19, 2020

I tried to follow this blog to make a cubejs+react sample.

After installing the backend, we could successfully launch http://localhost:4000 in a browser. Then, I tried to add a React dashboard in the browser. After some installation, the folder dashboard-app was generated. However, after npm run start, launching http://localhost:3000 returned an error:

./node_modules/@cubejs-client/core/dist/cubejs-client-core.js
Module not found: Can't resolve 'core-js/modules/es6.array.filter' in '/Users/chengtie/Startup/ReactProjects/mongo-tutorial/dashboard-app/node_modules/@cubejs-client/core/dist'

After chatting on Slack, Hassan Khan gave a solution: we need to install core-js@2 under dashboard-app by npm install core-js@2 --save. Here is the Slack link.

I guess this report may help you improve the sample.

@paveltiunov paveltiunov added this to the v0.17.10 milestone Feb 20, 2020
@paveltiunov
Copy link
Member

Hey @chengtie ! Thanks for posting this one! Should be fixed in 0.17.10. Could you please try create new project from scratch again?

@hassankhan
Copy link
Contributor

hassankhan commented Feb 20, 2020

Hi @paveltiunov, I thought the fix would be to add core-js as a dependency when generating a new dashboard app? Am I missing some context? 😀

@paveltiunov
Copy link
Member

@hassankhan Yeah. This is fast fix to reanimate dashboards. We need to find a solution on how to make babel work with core-js@3. I wasn't able to find it yet. Do you have any ideas here?

@hassankhan
Copy link
Contributor

hassankhan commented Feb 20, 2020

Did some digging, this link seems to have some interesting information.

Dependabot should probably open another PR soon attempting to re-upgrade core-js, we can continue the discussion (and any extra followup work) on that PR

@paveltiunov
Copy link
Member

@hassankhan Gotcha. Seems like babel is out of date on a build level rather than actually in created react app? Need to upgrade our babel for rollup build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants