Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preAggregationsSchema an option of CubejsServerCore #96

Closed
dtslvr opened this issue Apr 29, 2019 · 4 comments
Closed

Make preAggregationsSchema an option of CubejsServerCore #96

dtslvr opened this issue Apr 29, 2019 · 4 comments
Labels
enhancement New feature proposal help wanted Community contributions are welcome.
Milestone

Comments

@dtslvr
Copy link
Contributor

dtslvr commented Apr 29, 2019

Describe the bug
I'd like to override the default value of preAggregationsSchema (stb_pre_aggregations). When I define preAggregationsSchema in the query, I get the error Invalid query format: "preAggregationsSchema" is not allowed.

To Reproduce
Run the following query:

{
  "measures": ["Test.count"],
  "dimensions": ["Test.value"],
  "filters": [],
  "timeDimensions": [],
  "timezone": "CET",
  "preAggregationsSchema": "my_pre_aggregations"
}

Expected behavior
Cube.js uses the passed preAggregationsSchema from the query.

Version:
0.4.5

Additional context
preAggregationsSchema is not part of querySchema (https://github.com/statsbotco/cube.js/blob/master/packages/cubejs-api-gateway/index.js#L104)

@paveltiunov
Copy link
Member

@dtslvr Hey Thomas! It's actually intended. preAggregationsSchema is part of internal configuration that should be set up on server-wide level. I guess we can add it as CubejsServerCore option. Does it work for you?

@paveltiunov paveltiunov added the enhancement New feature proposal label Apr 29, 2019
@dtslvr
Copy link
Contributor Author

dtslvr commented Apr 30, 2019

Hi @paveltiunov, yes an option for preAggregationsSchema in CubejsServerCore makes totally sense.

@dtslvr dtslvr changed the title Invalid query format: preAggregationsSchema is not allowed Make preAggregationsSchema an option of CubejsServerCore Apr 30, 2019
@paveltiunov paveltiunov added the help wanted Community contributions are welcome. label Apr 30, 2019
paveltiunov added a commit that referenced this issue Aug 18, 2019
@paveltiunov paveltiunov added this to the v0.10.27 milestone Aug 18, 2019
@dtslvr
Copy link
Contributor Author

dtslvr commented Aug 30, 2019

I haven't received a notification that it's already done 🤔 Thanks @paveltiunov, will check it next week.

@dtslvr dtslvr mentioned this issue Aug 31, 2019
4 tasks
@dtslvr
Copy link
Contributor Author

dtslvr commented Aug 31, 2019

Works fine! I have created a pull request (#195) to update the typings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature proposal help wanted Community contributions are welcome.
Projects
None yet
Development

No branches or pull requests

2 participants