From 246805b9962702561340f8fa51583cc2fa7c7906 Mon Sep 17 00:00:00 2001 From: Pavel Tiunov Date: Thu, 27 Jun 2019 15:31:56 -0700 Subject: [PATCH] feat: More readable compiling schema log message --- packages/cubejs-server-core/core/CompilerApi.js | 2 +- packages/cubejs-server-core/core/index.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/cubejs-server-core/core/CompilerApi.js b/packages/cubejs-server-core/core/CompilerApi.js index db702cdf60a51..407c3c0a7f963 100644 --- a/packages/cubejs-server-core/core/CompilerApi.js +++ b/packages/cubejs-server-core/core/CompilerApi.js @@ -21,7 +21,7 @@ class CompilerApi { compilerVersion += `_${crypto.createHash('md5').update(JSON.stringify(files)).digest("hex")}`; } if (!this.compilers || this.compilerVersion !== compilerVersion) { - this.logger('Compiling schema', { version: compilerVersion }); + this.logger(this.compilers ? 'Recompiling schema' : 'Compiling schema', { version: compilerVersion }); // TODO check if saving this promise can produce memory leak? this.compilers = PrepareCompiler.compile(this.repository, { adapter: this.dbType, diff --git a/packages/cubejs-server-core/core/index.js b/packages/cubejs-server-core/core/index.js index ae05a189ef47a..36d7478ecbf44 100644 --- a/packages/cubejs-server-core/core/index.js +++ b/packages/cubejs-server-core/core/index.js @@ -131,7 +131,8 @@ class CubejsServerCore { msg === 'Orchestrator error' || msg === 'Internal Server Error' || msg === 'User Error' || - msg === 'Compiling schema' + msg === 'Compiling schema' || + msg === 'Recompiling schema' ) { this.event(msg, { error: params.error }); }