From 60d57040d44eedb3528b9cd55643a22c0b36836c Mon Sep 17 00:00:00 2001 From: Pavel Tiunov Date: Sat, 17 Aug 2019 19:06:42 -0700 Subject: [PATCH] feat: Make `preAggregationsSchema` an option of CubejsServerCore - missed option propagation Fixes #96 --- .../@cubejs-backend-server-core.md | 4 ++-- packages/cubejs-server-core/core/index.js | 3 ++- packages/cubejs-server-core/yarn.lock | 16 ++++++++-------- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/docs/Cube.js-Backend/@cubejs-backend-server-core.md b/docs/Cube.js-Backend/@cubejs-backend-server-core.md index 72ae76f3d5b19..7340b4187f850 100644 --- a/docs/Cube.js-Backend/@cubejs-backend-server-core.md +++ b/docs/Cube.js-Backend/@cubejs-backend-server-core.md @@ -218,7 +218,7 @@ CubejsServerCore.create({ }); ``` -### preAggregationSchema +### preAggregationsSchema Schema name to use for storing pre-aggregations. Either `String` or `Function` could be passed. @@ -226,7 +226,7 @@ Providing a `Function` allows to dynamically set the pre-aggregation schema name ```javascript CubejsServerCore.create({ - preAggregationSchema: ({ authInfo }) => `pre_aggregations_${authInfo.tenantId}` + preAggregationsSchema: ({ authInfo }) => `pre_aggregations_${authInfo.tenantId}` }); ``` diff --git a/packages/cubejs-server-core/core/index.js b/packages/cubejs-server-core/core/index.js index f71524aa0695f..74689e2b049a1 100644 --- a/packages/cubejs-server-core/core/index.js +++ b/packages/cubejs-server-core/core/index.js @@ -256,7 +256,8 @@ class CubejsServerCore { schemaVersion: options.schemaVersion || this.options.schemaVersion, devServer: this.options.devServer, logger: this.logger, - externalDbType: options.externalDbType + externalDbType: options.externalDbType, + preAggregationsSchema: options.preAggregationsSchema }); } diff --git a/packages/cubejs-server-core/yarn.lock b/packages/cubejs-server-core/yarn.lock index 895585706a509..5a617c618060e 100644 --- a/packages/cubejs-server-core/yarn.lock +++ b/packages/cubejs-server-core/yarn.lock @@ -2,10 +2,10 @@ # yarn lockfile v1 -"@cubejs-backend/api-gateway@^0.10.21": - version "0.10.21" - resolved "https://registry.yarnpkg.com/@cubejs-backend/api-gateway/-/api-gateway-0.10.21.tgz#0e1c1eb4ee57e86e839d53bef78b423976e72cdf" - integrity sha512-AMQdA9FgeZBB5/xqvYmmHSAz4K8Xd2IoZqdtQgaFquDQSU5gWm2D6x9Crw39XK6uhqrAXaIeSl1HZFp1JDtLxw== +"@cubejs-backend/api-gateway@^0.10.24": + version "0.10.24" + resolved "https://registry.yarnpkg.com/@cubejs-backend/api-gateway/-/api-gateway-0.10.24.tgz#99f0f1f26cbd1237144f26dc134711fbbbdbbb67" + integrity sha512-KuYJ/hv18EfiGkJKm/vweYGKLTcKiWlZe8I3FDfb0309fin/MeNCDqK6LmlNTgLWkizZtbRCmbbseuNYnHFiHw== dependencies: "@hapi/joi" "^14.0.6" chrono-node "^1.3.11" @@ -21,10 +21,10 @@ ramda "^0.24.1" redis "^2.8.0" -"@cubejs-backend/schema-compiler@^0.10.23": - version "0.10.23" - resolved "https://registry.yarnpkg.com/@cubejs-backend/schema-compiler/-/schema-compiler-0.10.23.tgz#55c1558c8442c163b35e1e8839baf67662a4f457" - integrity sha512-MowbtC9W24kAmfIRMYIEeREkPmN0vckWtRIzsrfO5bxLnCCM/RI3QlwDH9pLWJYt5rvTNCj85q1mlB1tQxrD2Q== +"@cubejs-backend/schema-compiler@^0.10.24": + version "0.10.24" + resolved "https://registry.yarnpkg.com/@cubejs-backend/schema-compiler/-/schema-compiler-0.10.24.tgz#938187db523e571ba17f1e17971454301923b101" + integrity sha512-LP7Np9wsmHixx+NthQNL1eoqAqd4WscRap2mmKB4/YRkf2KoGsEUPIYooDlo9jjZy84sW/fMeZkZ72VM/HBZCg== dependencies: "@hapi/joi" "^14.3.1" babel-generator "^6.25.0"