Skip to content

Commit

Permalink
fix: minute requests incorrectly snapped to daily partitions
Browse files Browse the repository at this point in the history
  • Loading branch information
paveltiunov committed Mar 30, 2020
1 parent d1b9b44 commit 8fd7876
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/cubejs-schema-compiler/adapter/BaseTimeDimension.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const UserError = require('../compiler/UserError');

const TIME_SERIES = {
day: (range) =>
Array.from(range.by('day'))
Array.from(range.snapTo('day').by('day'))
.map(d => [d.format('YYYY-MM-DDT00:00:00.000'), d.format('YYYY-MM-DDT23:59:59.999')]),
month: (range) =>
Array.from(range.snapTo('month').by('month'))
Expand All @@ -15,13 +15,13 @@ const TIME_SERIES = {
Array.from(range.snapTo('year').by('year'))
.map(d => [d.format('YYYY-01-01T00:00:00.000'), d.endOf('year').format('YYYY-MM-DDT23:59:59.999')]),
hour: (range) =>
Array.from(range.by('hour'))
Array.from(range.snapTo('hour').by('hour'))
.map(d => [d.format('YYYY-MM-DDTHH:00:00.000'), d.format('YYYY-MM-DDTHH:59:59.999')]),
minute: (range) =>
Array.from(range.by('minute'))
Array.from(range.snapTo('minute').by('minute'))
.map(d => [d.format('YYYY-MM-DDTHH:MM:00.000'), d.format('YYYY-MM-DDTHH:MM:59.999')]),
second: (range) =>
Array.from(range.by('second'))
Array.from(range.snapTo('second').by('second'))
.map(d => [d.format('YYYY-MM-DDTHH:MM:SS.000'), d.format('YYYY-MM-DDTHH:MM:SS.999')]),
week: (range) =>
Array.from(range.snapTo('isoweek').by('week'))
Expand Down

0 comments on commit 8fd7876

Please sign in to comment.