From c1eb113b35e123d4db2686fc77692b3a7ac39152 Mon Sep 17 00:00:00 2001 From: Pavel Tiunov Date: Wed, 31 Jul 2019 16:14:32 -0700 Subject: [PATCH] fix: BigQuery external rollup compatibility: use `__` separator for member aliases. Fix missed override. --- packages/cubejs-schema-compiler/adapter/BigqueryQuery.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/cubejs-schema-compiler/adapter/BigqueryQuery.js b/packages/cubejs-schema-compiler/adapter/BigqueryQuery.js index ac175ce24b10f..5b88e98e99e8d 100644 --- a/packages/cubejs-schema-compiler/adapter/BigqueryQuery.js +++ b/packages/cubejs-schema-compiler/adapter/BigqueryQuery.js @@ -50,10 +50,6 @@ class BigqueryQuery extends BaseQuery { return new BigqueryFilter(this, filter); } - aliasName(name) { - return super.aliasName(name).replace(/\./g, '_'); - } - dateSeriesSql(timeDimension) { return `${timeDimension.dateSeriesAliasName()} AS (${this.seriesSql(timeDimension)})`; }