fix: Athena doesn't support _ in contains filter

cube-js · Aug 22, 2019 · d330be4 · d330be4
1 parent 682904d
commit d330be4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/cubejs-athena-driver/driver/AthenaDriver.js b/packages/cubejs-athena-driver/driver/AthenaDriver.js
@@ -2,7 +2,6 @@ const AWS = require('aws-sdk');
 const { promisify } = require('util');
 const BaseDriver = require('@cubejs-backend/query-orchestrator/driver/BaseDriver');
 const SqlString = require('sqlstring');
-const crypto = require('crypto');
 
 const applyParams = (query, params) => {
   return SqlString.format(query, params);
@@ -32,11 +31,17 @@ class AthenaDriver extends BaseDriver {
   sleep(ms) {
     return new Promise((resolve) => {
       setTimeout(() => resolve(), ms);
-    })
+    });
   }
 
   async query(query, values) {
-    const queryString = applyParams(query, values);
+    const queryString = applyParams(
+      query,
+      values.map(s => (typeof s === 'string' ? {
+        toSqlString: () => SqlString.escape(s).replace(/\\\\([_%])/g, '\\$1')
+      } : s))
+    );
+    console.log(queryString);
     const { QueryExecutionId } = await this.athena.startQueryExecutionAsync({
       QueryString: queryString,
       ResultConfiguration: {
@@ -84,4 +89,4 @@ class AthenaDriver extends BaseDriver {
   }
 }
 
-module.exports = AthenaDriver;
+module.exports = AthenaDriver;
diff --git a/packages/cubejs-schema-compiler/adapter/PrestodbQuery.js b/packages/cubejs-schema-compiler/adapter/PrestodbQuery.js
@@ -11,7 +11,7 @@ const GRANULARITY_TO_INTERVAL = {
 
 class PrestodbFilter extends BaseFilter {
   likeIgnoreCase(column, not) {
-    return `LOWER(${column})${not ? ' NOT' : ''} LIKE CONCAT('%', LOWER(?) ,'%')`;
+    return `LOWER(${column})${not ? ' NOT' : ''} LIKE CONCAT('%', LOWER(?) ,'%') ESCAPE '\\'`;
   }
 
   castParameter() {