Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

False positive for isBadAndroid #558

Closed
miketaylr opened this issue Dec 17, 2013 · 3 comments
Closed

False positive for isBadAndroid #558

miketaylr opened this issue Dec 17, 2013 · 3 comments
Assignees
Labels

Comments

@miketaylr
Copy link

On https://github.com/cubiq/iscroll/blob/master/src/utils.js#L84-L85,

/Android/.test(window.navigator.appVersion) && !(/Chrome\/\d/.test(window.navigator.appVersion));

will return true for Firefox for Android (because that returns 5.0 (Android) for navigator.appVersion.

Is the real point of this test to find non-Chrome stock browsers and webviews?

@cubiq
Copy link
Owner

cubiq commented Dec 17, 2013

yeah I've got this, thanks. It should be enough to add a space after Android. I'll make some more tests. Android is a real hell.

@ghost ghost assigned cubiq Dec 17, 2013
@miketaylr
Copy link
Author

Heh, truth. Happy to sign a CLA and send a pull request for a space if you're busy. 👍

@cubiq cubiq closed this as completed Jan 9, 2014
@jhnns
Copy link

jhnns commented Jan 9, 2014

Android is a real hell.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants