Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer testing against rust panic messages #433

Open
UnsignedByte opened this issue Mar 16, 2024 · 0 comments
Open

No longer testing against rust panic messages #433

UnsignedByte opened this issue Mar 16, 2024 · 0 comments
Labels
C: Internals Component: Compiler internals low priority We're probably not going to work on this anytime soon S: needs triage Status: Needs some more thinking before being actionable

Comments

@UnsignedByte
Copy link
Collaborator

An issue I noticed recently when updating the rust version is that our error messages changed due to the update of rust. #429 shows some of the changes in the .expect files. I mentioned this to adrian and he recommended maybe stepping away from relying on rust's error messages and using our own error system more, and I agree.

I think we have a weird combination at the moment of some compiler errors having our nice error system and some others just being thread 'main panicked..., and at some point we should clean this up to make it more readable and in the case that we ever make a release build which might not have all this debug info.

Pretty low priority but something to keep on the radar.

@UnsignedByte UnsignedByte added low priority We're probably not going to work on this anytime soon S: needs triage Status: Needs some more thinking before being actionable C: Internals Component: Compiler internals labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Internals Component: Compiler internals low priority We're probably not going to work on this anytime soon S: needs triage Status: Needs some more thinking before being actionable
Projects
None yet
Development

No branches or pull requests

1 participant