Close files on SpawnProcess#stop

[JonRowe]

Alternate implementation to #149

SpawnProcess creates files to use for stdout and stderr which are opened but never closed, this leaks file descriptors that eventually cause larger test suites to fail on some systems (I encountered this with rspec-core ).

This implementation closes the tmp files during the SpawnProcess#stop(reader) thus cleaning up the files and preventing the issue, however this causes an issue if steps attempt to access the files after the process has finished, to handle that eventuality the output of reading the streams is captured and used in the event of an IOError.

[jarl-dk]

That looks good. I guess the rescue is to handle the case where the process is done (@process is nil) and files are closed. I'd rather see that this particular situation is handled explicitly with an if condition and remove the rescue clause and leave exceptions to exceptional situations...

[JonRowe]

I did try using an if even though I have an irrational hatred of them, but I couldn't make it a nicer solution, mainly because you can't actually check that files are closed or open other than to try reading/writing to them. I might try again.

[jarl-dk]

I would even go so far as to set @out = nil (the same for @err) in #stop. But before you close (and delete) them in #stop you must ensure to read all content and put it in the _cache equivalent.

[JonRowe]

You might prefer this version...

[jarl-dk]

How about this? https://github.com/cucumber/aruba/tree/close_tmp_files_on_stop its this PR with one additional commit (1fd252e)

[JonRowe]

Works for me.

[JonRowe]

Thanks :)

[jarl-dk]

Thanks again for your involvement and contribution.