Cleanup "Process Management" #1 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
This was referenced Jun 2, 2015
|
I think this should be reviewed "now". I create a follow-up PR to improve command execution a bit more. |
| I want to use some debugger in my code and therefor need system() to execute my program | ||
| In order to find a bug | ||
|
|
||
| @debug |
| @@ -185,8 +185,8 @@ Then wire it all up in your `features/support/env.rb` file: | |||
| require 'aruba' | |||
| require 'aruba/in_process' | |||
|
|
|||
| Aruba::InProcess.main_class = MyMain | |||
| Aruba.process = Aruba::InProcess | |||
| Aruba.process = Aruba::Processes::InProcess | |||
There was a problem hiding this comment.
There are quite a few classes around starting processes. That's why I namespaced them.
|
@mattwynne What do you think about that PR? It's just the beginning, but I hope this is the right direction. It lays the groundwork to introduce the new config in #258. |
| @@ -0,0 +1,21 @@ | |||
| module Aruba | |||
| module Utils | |||
There was a problem hiding this comment.
I suggest Platform as the name. Utils is too general and could become a dumping-ground.
maxmeyer
added a commit
that referenced
this pull request
Jun 26, 2015
…_directory_for_process Cleanup "Process Management" #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one cleans up
Process Management. Will create a new PR for the next iteration of cleanup.