Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure examples work on all supported platforms #453

Closed
2 of 5 tasks
maxmeyer opened this issue Jul 13, 2017 · 11 comments
Closed
2 of 5 tasks

Make sure examples work on all supported platforms #453

maxmeyer opened this issue Jul 13, 2017 · 11 comments

Comments

@maxmeyer
Copy link
Member

maxmeyer commented Jul 13, 2017

Summary

Run the examples in our README for cucumber, rspec and minitest.

@enkessler @mvz @olleolleolle Would you mind to run the examples found in our "Getting started"-section (Your First Tests with "aruba") on your machines? I modified them yesterday to show how to run and test commands with aruba. Do you think the examples are easy to understand for beginners?

Expected Behavior

  • The examples do work
  • The examples are easy to understand
  • The examples work on all platforms
    • Windows
    • Linux
    • Mac OS

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context & Motivation

Your Environment

  • Version used:
  • Operating System and version:
  • Link to your project:
@olleolleolle
Copy link
Contributor

olleolleolle commented Jul 13, 2017

OS X: I have now tried the examples, in the same repo checkout, after each other. It all works.

@maxmeyer
Copy link
Member Author

@olleolleolle Thanks!

@mvz
Copy link
Contributor

mvz commented Jul 16, 2017

The examples all work on Linux, but I have three remarks:

  • To ensure all dependencies are available from the start, I think you should add bundle to the start of the instructions, just after the clone.
  • For some reason, spec_helper.rb already exists in that repo. Since you know this is the case, it would be more straightforward if the instructions just stated something like 'Add the following line to spec_helper.rb.
  • The $LOAD_PATH line in the minitest example is not needed, since -Ilib:test is part of the command line.

@olleolleolle
Copy link
Contributor

@mvz Re: dependencies, do you mean an addition to the README like https://github.com/cucumber/aruba/pull/454/files

@mvz
Copy link
Contributor

mvz commented Jul 16, 2017

@olleolleolle no, that pull request exactly fixes that point.

@maxmeyer maxmeyer mentioned this issue Jul 16, 2017
7 tasks
@maxmeyer
Copy link
Member Author

@mvz Thanks for the feedback! I addressed your comments in #456.

@maxmeyer
Copy link
Member Author

@mvz Would you mind joining the Cucumber Slack Room?

@maxmeyer
Copy link
Member Author

@maxmeyer
Copy link
Member Author

BTW: I also updated our docs on RubyDocs.info as some of our users tried things they found in there.

@maxmeyer
Copy link
Member Author

Shall be fixed for now. @mvz @olleolleolle Feel free to add more comments after closure.

@mvz
Copy link
Contributor

mvz commented Jul 29, 2017

Would you mind joining the Cucumber Slack Room?

Request sent, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants