Added file size specific steps to the Aruba API. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattwynne, I noticed some activity on this in #91 by @robertwahler. Thinking it might be better to wait for some of the initial specs to get merged in and then work off of that. |
|
Hey @hectcastro there are specs on master now. Please feel free to add some spec for this patch and I'll merge it in. |
|
@mattwynne How does this look? |
|
Added. |
mattwynne
added a commit
that referenced
this pull request
Jan 4, 2012
Added file size specific steps to the Aruba API.
|
Awesome! Thanks @hectcastro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am building a command line tool that requires input files of a certain size as arguments – for example, file size must be greater than
5MB. In order to use Aruba and Cucumber to test, I added some additional steps and methods to the API.Let me know if you have any feedback on this pull request, and thanks for creating/maintaining Aruba!