From dab342d461fb78828a46dd93b2759a36e3348c31 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 5 Jul 2019 19:03:15 +0200 Subject: [PATCH 1/3] Remove unused @interactive ivar from step --- lib/aruba/cucumber/command.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/aruba/cucumber/command.rb b/lib/aruba/cucumber/command.rb index 137931b57..f70635109 100644 --- a/lib/aruba/cucumber/command.rb +++ b/lib/aruba/cucumber/command.rb @@ -23,8 +23,7 @@ end When(/^I run `([^`]*)` interactively$/) do |cmd| - cmd = sanitize_text(cmd) - @interactive = run_command(cmd) + run_command(sanitize_text(cmd)) end # Merge interactive and background after refactoring with event queue From 0c2de9161681179b67b06874eca6546d454c436e Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 5 Jul 2019 19:03:48 +0200 Subject: [PATCH 2/3] Stop skipping scenarios that work fine on JRuby --- features/06_use_aruba_cli/open_console.feature | 3 --- 1 file changed, 3 deletions(-) diff --git a/features/06_use_aruba_cli/open_console.feature b/features/06_use_aruba_cli/open_console.feature index 88f95dc99..e6ad6d78f 100644 --- a/features/06_use_aruba_cli/open_console.feature +++ b/features/06_use_aruba_cli/open_console.feature @@ -11,7 +11,6 @@ Feature: Aruba Console aruba:001:0> """ - @unsupported-on-platform-java Scenario: Show help Given I run `aruba console` interactively And I type "aruba_help" @@ -29,7 +28,6 @@ Feature: Aruba Console Documentation: """ - @unsupported-on-platform-java Scenario: Show methods Given I run `aruba console` interactively And I type "aruba_methods" @@ -43,7 +41,6 @@ Feature: Aruba Console * setup_aruba """ - @unsupported-on-platform-java Scenario: Has history Given I run `aruba console` interactively And I type "aruba_methods" From d3d606a8011d3b43cde37e2aeb825d57e57f8307 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Sat, 6 Jul 2019 12:52:12 +0200 Subject: [PATCH 3/3] Skip debug feature on JRuby This feature does not actually work fully on JRuby. The debugger will start, but after that, interaction with it is impossible. --- .../cucumber/steps/command/debug_your_command_in_aruba.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/03_testing_frameworks/cucumber/steps/command/debug_your_command_in_aruba.feature b/features/03_testing_frameworks/cucumber/steps/command/debug_your_command_in_aruba.feature index e4eaafbeb..529d8e6fd 100644 --- a/features/03_testing_frameworks/cucumber/steps/command/debug_your_command_in_aruba.feature +++ b/features/03_testing_frameworks/cucumber/steps/command/debug_your_command_in_aruba.feature @@ -7,7 +7,7 @@ Feature: Debug your command in cucumber-test-run Given I use a fixture named "cli-app" And the default aruba exit timeout is 60 seconds - @requires-readline + @unsupported-on-platform-java Scenario: You can use a debug repl in your cli program If you want to debug an error, which only occurs in one of your