Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test run identifiers and hook types #118

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Nov 10, 2024

🤔 What's changed?

Regenerates the messages with the latest schema and new reference behaviour from cucumber/fake-cucumber#131, specifically:

  • TestRunStarted.id
  • TestCase.testRunStartedId
  • TestRunFinished.testRunStartedId
  • Hook.type

This produces a bit of a bigger diff than you might expect, because the addition of TestRunStarted.id means the incrementing ids all shift up one.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Feat/messages 27 phase 1 Add test run identifiers and hook types Nov 10, 2024
Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As/when we release this just need to think if it's a major. EDIT: At first glance I don't think it is

@davidjgoss
Copy link
Contributor Author

As/when we release this just need to think if it's a major. EDIT: At first glance I don't think it is

I think it’s breaking in the basis that if you pull it in, you have to make changes for the suite to pass.

@davidjgoss davidjgoss merged commit 40c8143 into main Nov 11, 2024
2 checks passed
@davidjgoss davidjgoss deleted the feat/messages-27-phase-1 branch November 11, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants