Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cucumber's own features to use cucumber-expressions (from regexes) #1871

Open
mattwynne opened this issue Dec 10, 2021 · 9 comments
Open
Labels
🏦 debt Tech debt good first issue Good for newcomers

Comments

@mattwynne
Copy link
Member

Right now we're using regular expressions in our own step definitions.

It would be good to change these over to using cucumber expressions (and parameter types!) so that we're providing a good example of how Cucumber should be used.

@mattwynne mattwynne added 🏦 debt Tech debt good first issue Good for newcomers labels Dec 10, 2021
@davidjgoss
Copy link
Contributor

Agreed!

@aslakhellesoy
Copy link
Contributor

If you're mobbing with new contributors on this - show them https://cucumber.github.io/cucumber-expressions/ !

@ghost
Copy link

ghost commented Feb 18, 2022

Hi @mattwynne, I would like to contribute to this issue.

@mattwynne
Copy link
Member Author

Awesome @shvmsnju, let me know if you need any help.

This was referenced Feb 19, 2022
@pk
Copy link

pk commented Jun 8, 2023

Is this issues still valid/pending? I could have a look to get started with the code base.

@davidjgoss
Copy link
Contributor

@pk absolutely, feel free to raise PRs and let me know if you need any pointers.

@pk
Copy link

pk commented Jun 12, 2023

Perfect, we are using Cucumber so much that we really would like to contribute. Also our test suites are getting more and more complex and we may need to start to use some features from API, running the Features dynamically so it would be nice to contribute before I start asking too many questions. ;)

@pk
Copy link

pk commented Jun 12, 2023

OK, I've looked into this and I think this task is done.

There are steps under compability/**/*.ts and features/step_definitions/*.ts all of which has been converted into the Cucumber Expressions.

I've done search for Given/When/Then with the RegExp patterns and it really yields references to the steps with RegExp only in *.md files.

I may be missing something....

@davidjgoss
Copy link
Contributor

Sorry for the confusion @pk - updating the examples in the .md docs would be equally valuable though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants