-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Cucumber's own features to use cucumber-expressions (from regexes) #1871
Comments
Agreed! |
If you're mobbing with new contributors on this - show them https://cucumber.github.io/cucumber-expressions/ ! |
Hi @mattwynne, I would like to contribute to this issue. |
Awesome @shvmsnju, let me know if you need any help. |
Is this issues still valid/pending? I could have a look to get started with the code base. |
@pk absolutely, feel free to raise PRs and let me know if you need any pointers. |
Perfect, we are using Cucumber so much that we really would like to contribute. Also our test suites are getting more and more complex and we may need to start to use some features from API, running the Features dynamically so it would be nice to contribute before I start asking too many questions. ;) |
OK, I've looked into this and I think this task is done. There are steps under I've done search for Given/When/Then with the RegExp patterns and it really yields references to the steps with RegExp only in *.md files. I may be missing something.... |
Sorry for the confusion @pk - updating the examples in the .md docs would be equally valuable though! |
Right now we're using regular expressions in our own step definitions.
It would be good to change these over to using cucumber expressions (and parameter types!) so that we're providing a good example of how Cucumber should be used.
The text was updated successfully, but these errors were encountered: