Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG Update for cucumber/cucumber #251 #915

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Aug 24, 2017

Summary

CHANGELOG.md updates as per cucumber/cucumber #251

Details

I've run my changelog_updater and have gone through to fix other nuanced items, mainly ordering of issue tags and credit tags in a single set of parens after the changed line.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update

@mxygem mxygem merged commit 2a8f3a0 into master Aug 24, 2017
@mxygem
Copy link
Member Author

mxygem commented Aug 24, 2017

No change to code done, only CHANGELOG, so not concerned with the status of tests.

@mxygem mxygem deleted the changelog-update branch August 24, 2017 02:10
@mxygem mxygem restored the changelog-update branch August 24, 2017 06:12
@mxygem
Copy link
Member Author

mxygem commented Aug 24, 2017

Hey! So, as a heads up, I got a bit eager in making some doc updates and moved forward without being fully aware of various processes. With that said, if my merging and deleting branches too soon has caused issues and you'd like me to fix or flat out revert this PR, happy to do so as I definitely don't want to cause issues/step on toes. If you have a preferred fix method you'd like me to run, please send it my way.

Thanks and sorry if this has caused any troubles!

Check out the #committers channel in Slack for more.

@charlierudolph charlierudolph deleted the changelog-update branch December 8, 2017 17:22
@lock
Copy link

lock bot commented Dec 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant