Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven distribution relocation #1336

Closed
boaty82 opened this issue Mar 20, 2018 · 13 comments
Closed

Maven distribution relocation #1336

boaty82 opened this issue Mar 20, 2018 · 13 comments
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team 🧷 pinned Tells Stalebot not to close this issue
Milestone

Comments

@boaty82
Copy link
Contributor

boaty82 commented Mar 20, 2018

Please can you for each project setup a relocation notification of your move from info.cukes to io.cucumber

e.g. as per jackson
https://mvnrepository.com/artifact/org.codehaus.jackson/jackson-mrbean
screen shot 2018-03-20 at 16 18 08

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

@boaty82 boaty82 changed the title Setup distribution relocation Maven distribution relocation Mar 20, 2018
@mpkorstanje
Copy link
Contributor

It's actually quite involved to do this and all of the 0.57 people involved in project are volunteering their time. If you want to help out that'd be awesome!

You could checkout the 2.0.0 version, create a branch, remove all the code and prepare the relocation poms with signing plugin as described in this stackoverflow post.

@boaty82
Copy link
Contributor Author

boaty82 commented Mar 23, 2018

0.57 people how’s that possible? LOL

Sure thing I’m on vacation soon but will endeavour to do this on the train one day

@mlvandijk
Copy link
Member

That would be: less than one full time person... (As we all have day jobs.)

@mlvandijk
Copy link
Member

Therefore: help much appreciated!

@boaty82
Copy link
Contributor Author

boaty82 commented Mar 23, 2018

I assumed you meant FTEs 😜

@mpkorstanje
Copy link
Contributor

Sure thing I’m on vacation soon but will endeavour to do this on the train one day

Awesome!

@mlvandijk
Copy link
Member

@boaty82 yes :)

@stale
Copy link

stale bot commented May 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label May 23, 2018
@boaty82
Copy link
Contributor Author

boaty82 commented May 23, 2018

I haven’t forgot about this. Just been working on the parallel feature

@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label May 23, 2018
@mpkorstanje mpkorstanje added the 🧷 pinned Tells Stalebot not to close this issue label May 23, 2018
@mlvandijk mlvandijk added the Maven label Jul 3, 2018
@mpkorstanje mpkorstanje added 🙏 help wanted Help wanted - not prioritized by core team good first issue Good for newcomers labels Dec 11, 2018
@mpkorstanje
Copy link
Contributor

So I tried to set this up locally.

https://github.com/cucumber/cucumber-jvm/tree/relocation-notification

And I can't get this to work. The version update is shown but not the change in groupId. Puzzling. I've send an email to mvnrepository.com to see how they do this.

mpkorstanje@logarithmicwhale:~/Projects/cucumber/cucumber-java-skeleton$ mvn versions:display-dependency-updates 
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Building Cucumber-Java Skeleton 0.0.1
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- versions-maven-plugin:2.5:display-dependency-updates (default-cli) @ cucumber-java-skeleton ---
[INFO] The following dependencies in Dependencies have newer versions:
[INFO]   info.cukes:cucumber-java .............................. 1.2.5 -> 2.0.0
[INFO]   info.cukes:cucumber-junit ............................. 1.2.5 -> 2.0.0
[INFO]   junit:junit ...................................... 4.12 -> 4.13-beta-2
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.776 s
[INFO] Finished at: 2019-03-02T18:06:11+01:00
[INFO] Final Memory: 15M/212M
[INFO] ------------------------------------------------------------------------

@mpkorstanje
Copy link
Contributor

I'm giving up on this. It would be nice but I can't work out how it is supposed to be done.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Aug 27, 2019

@nhojpatrick just pushed

probably easier to do a new clone and then switch to the new branch “v1.2.6-relocation-release”

info.cukes subdir has the relocation information and very slim pom files

  • the scm tag might need to be removed so the install/deploy/release process does that
  • other deploy/release config might need to be added back in like gpg, developers, license, etc

io.cucumber subdir is a copy of 1.2.5 but with the io.cucumber groupId and versioned 1.2.6. So > if people upgrade they won’t get anything new but maven etc will notify them of the groupId relocation in the build output

@mpkorstanje
Copy link
Contributor

Just did the release. After updating to 1.2.6 I get the message:

mpkorstanje@nyx:~/Projects/cucumber/cucumber-java-skeleton$ mvn clean test
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< cucumber:cucumber-java-skeleton >-------------------
[INFO] Building Cucumber-Java Skeleton 0.0.1
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] The artifact info.cukes:cucumber-java:jar:1.2.6 has been relocated to io.cucumber:cucumber-java:jar:1.2.6
[WARNING] The artifact info.cukes:cucumber-junit:jar:1.2.6 has been relocated to io.cucumber:cucumber-junit:jar:1.2.6
[INFO] 

After changing groupIds I get:

mpkorstanje@nyx:~/Projects/cucumber/cucumber-java-skeleton$ mvn versions:display-dependency-updates
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< cucumber:cucumber-java-skeleton >-------------------
[INFO] Building Cucumber-Java Skeleton 0.0.1
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- versions-maven-plugin:2.5:display-dependency-updates (default-cli) @ cucumber-java-skeleton ---
[INFO] artifact io.cucumber:cucumber-java: checking for updates from central
[INFO] artifact io.cucumber:cucumber-junit: checking for updates from central
[INFO] The following dependencies in Dependencies have newer versions:
[INFO]   io.cucumber:cucumber-java ......................... 1.2.6 -> 5.0.0-RC1
[INFO]   io.cucumber:cucumber-junit ........................ 1.2.6 -> 5.0.0-RC1
[INFO]   junit:junit ........................................ 4.12 -> 4.13-rc-1
[INFO] 

Thanks for looking into all this @nhojpatrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team 🧷 pinned Tells Stalebot not to close this issue
Projects
None yet
Development

No branches or pull requests

3 participants