Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.1] Wrong CompatVersion passed to JRuby when 1.9 is given #415

Closed
raniemi opened this issue Nov 6, 2012 · 2 comments · Fixed by #460
Closed

[1.1.1] Wrong CompatVersion passed to JRuby when 1.9 is given #415

raniemi opened this issue Nov 6, 2012 · 2 comments · Fixed by #460

Comments

@raniemi
Copy link

raniemi commented Nov 6, 2012

WHAT: RUBY_VERSION 1.8 is used when 1.9 is given in the cucumber-jruby.properties file

AFFECTS: master, 1.1.1

FILE: https://github.com/cucumber/cucumber-jvm/blob/master/jruby/src/main/java/cucumber/runtime/jruby/JRubyBackend.java

WHERE: line 63:65

if ("1.9".equals(rubyVersion)) {
    jruby.setCompatVersion(CompatVersion.RUBY1_8);
}

FIX:

if ("1.9".equals(rubyVersion)) {
    jruby.setCompatVersion(CompatVersion.RUBY1_9);
}
@aslakhellesoy
Copy link
Contributor

Thanks. Could you create a pull request please?

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
mpkorstanje pushed a commit that referenced this issue Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants