Bring clojure-native up to date with master HEAD #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: clojure/src/main/java/cucumber/runtime/clojure/ClojureBackend.java clojure/src/main/java/cucumber/runtime/clojure/ClojureHook.java clojure/src/main/java/cucumber/runtime/clojure/ClojureHookDefinition.java clojure/src/main/java/cucumber/runtime/clojure/ClojureStepDefinition.java
…to apply cleanly to master HEAD Changed cucumber.runtime.clj to implement cucumber.runtime.clj.Backend#loadGlue Implemented getSnippet to return the same snippets as ClojureBackend.java did Fixed a problem with creating TagExpression in add-hook-definition Added additional feature to execute clojure-snippet Added Before and After step definitions to execute add-hook-definition
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #138 (comment), I've brought @hiredman clojure-native up to date with master HEAD.
I had to add xstream as test dependency to a lot of pom.xml to be able to run all tests. Those changes are included with the pull request.
I also added a scenario and some step definitions to make sure all parts of the clojure backend are executed. Maybe someone with better Clojure skills can replace those with unit tests.
Please note that the pull request (with the exception of added clojure snippets) is functionally equivalent to @hiredman 's version, which in turn seems to be equivalent to the former Java-based implementation.
Thus,
buildWorld,disposeWorldandsetUnreportedStepExecutordo nothing yet.Oh, and my apologies for messing with whitespace in clojure/pom.xml despite your warning. If this is a problem, just comment and I'll try to fix it.