Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Clojure DSL syntax cleaner (rewritten as modification of new back-end) #267

Merged
merged 1 commit into from
Mar 20, 2012

Conversation

rplevy-draker
Copy link
Contributor

No description provided.

@rplevy-draker
Copy link
Contributor Author

This replaces #248, so I closed that one.

@nilswloka
Copy link
Member

You probably want to change the template function for the reified Snippet in clojure-snippet (https://github.com/cucumber/cucumber-jvm/blob/master/clojure/src/main/clj/cucumber/runtime/clj.clj#L22) to reflect the new syntax.

@rplevy-draker
Copy link
Contributor Author

Hmm, good catch. So this is where it suggests a definition for a missing feature...

@aslakhellesoy
Copy link
Contributor

I moved the old to ClojureSnippet class from main to test in https://github.com/cucumber/cucumber-jvm/blob/master/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippet.java

Now its only purpose is to test snippets, and we must manually make sure the snippet templates are in sync. That's fine.

I'll go ahead and change it.

@rplevy-draker
Copy link
Contributor Author

I actually wrote it earlier, but there was an internet outage, so I went out to enjoy the nice weather. I'll make it work with this change right now.

@aslakhellesoy
Copy link
Contributor

Just about to push now :-)

Let me know if that's not right...

aslakhellesoy added a commit that referenced this pull request Mar 20, 2012
aslakhellesoy added a commit that referenced this pull request Mar 20, 2012
@aslakhellesoy aslakhellesoy merged commit f48aa96 into cucumber:master Mar 20, 2012
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants