Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-rails incompatible with latest cucumber-ruby #538

Closed
kmarcisz opened this issue Jun 1, 2022 · 10 comments · Fixed by #541
Closed

cucumber-rails incompatible with latest cucumber-ruby #538

kmarcisz opened this issue Jun 1, 2022 · 10 comments · Fixed by #541

Comments

@kmarcisz
Copy link

kmarcisz commented Jun 1, 2022

👓 What did you see?

When updating to latest cucumber-ruby I couldn't jump to version 8 without dropping to much older version of cucumber-rails.

root@00fe90130848:/usr/src/app# bundle update --conservative cucumber cucumber-rails
(...)
Fetching cucumber 8.0.0 (was 7.1.0)
Installing cucumber 8.0.0 (was 7.1.0)
(...)
Fetching cucumber-rails 1.4.0 (was 2.5.1)
Installing cucumber-rails 1.4.0 (was 2.5.1)
(...)
Note: cucumber-rails version regressed from 2.5.1 to 1.

✅ What did you expect to see?

I expected to see both cucumber-ruby and cucumber-rails be updated to newest published versions.

📦 Which tool/library version are you using?

Rails 7.0.3
Ruby 2.7.6

🔬 How could we reproduce it?

Steps to reproduce the behavior:

  1. Set up a new Rails project
  2. Add gem cucumber to Gemfile
  3. Run command bundle install
  4. See version 1.x of cucumber-rails installed and not version 2.x
@luke-hill
Copy link
Contributor

Because we don't permit it yet.

@aslakhellesoy
Copy link
Contributor

So let’s keep this open as a reminder to make cucumber-rails compatible with cucumber-ruby 8.

@aslakhellesoy aslakhellesoy reopened this Jun 8, 2022
@aslakhellesoy aslakhellesoy changed the title cucumber-rails incomaptible with latest cucumber-ruby cucumber-rails incompatible with latest cucumber-ruby Jun 8, 2022
@mattwynne
Copy link
Member

Thanks for the feedback @kmarcisz!

Would you like to help us fix it? I guess we just need a new release of cucumber-rails with the dependency updated.

If you'd like to book some time to pair on it, you can access my calendar here.

@mattwynne mattwynne mentioned this issue Jun 9, 2022
1 task
@mattwynne mattwynne linked a pull request Jun 9, 2022 that will close this issue
@mattwynne
Copy link
Member

Here we go: #541. Needs a release now.

@mattwynne
Copy link
Member

mattwynne commented Jun 9, 2022

I would like to set up #546 as part of delivering this.

@svenwin
Copy link
Member

svenwin commented Jul 1, 2022

Just checked out cucumber-rails@main in one of our projects and bumped Cucumber to v8. It's working smoothly out of the box! I just need a release version now 🤣

@luke-hill
Copy link
Contributor

Cheers. I'll get on it soon. We've just been fixing up a bunch of stuff with the pipelines e.t.c. so there will be quite a lot of non-package related fixes.

@kevindew
Copy link

@luke-hill is there any chance this will be released soon?

@luke-hill
Copy link
Contributor

Sorry I have been swamped in other stuff and been a bit fluey. I'll get on this soon.

@kevindew
Copy link

No worries, hope you’re feeling better now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants