Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two different license files #20

Open
ryandesign opened this issue Aug 10, 2024 · 2 comments · May be fixed by #25
Open

Two different license files #20

ryandesign opened this issue Aug 10, 2024 · 2 comments · May be fixed by #25

Comments

@ryandesign
Copy link
Contributor

ryandesign commented Aug 10, 2024 •
edited
Loading

There are now two different curl license files: the original one at LICENSE and the newly added one at LICENSES/curl.txt. It should be possible to have a single license file that satisfies both REUSE requirements and allows GitHub to identify and display the license, in which one of these files is a symlink to the other. I forget which direction the symlink needs to be made to make both parties happy but I have seen it done in another repository.
@samueloph
Copy link
Member

I've tried symlinks both ways and neither worked 100%:
ln -s LICENSE LICENSES/curl.txt
https://github.com/samueloph/wcurl?tab=License-1-ov-file - Doesn't show the license, only the name of the license file

ln -s LICENSES/curl.txt LICENSE
https://github.com/curl/wcurl/actions/runs/10336819570/job/28612972401 - Fails the REUSE compliance check.

sergiodj pushed a commit to sergiodj/wcurl that referenced this issue Aug 30, 2024
LICENSES/curl.txt: Sync with LICENSE from the project root
1132030 
Closes curl#20

Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
@sergiodj sergiodj linked a pull request Aug 30, 2024 that will close this issue
Open
@ryandesign
Copy link
Contributor Author

According to ansible-community/community-topics#112 (comment), having the real file be the top-level COPYING (or LICENSE) file (so that GitHub can detect the license) and having a symlink to it in the LICENSES directory (for REUSE) should have worked. If this failed the REUSE compliance check, then the REUSE compliance check should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve/simplify LICENSE files (and create AUTHORS file) sergiodj/wcurl
2 participants
@ryandesign @samueloph