Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make neovim deploy more robust #2584

Open
pokey opened this issue Jul 26, 2024 · 0 comments
Open

Make neovim deploy more robust #2584

pokey opened this issue Jul 26, 2024 · 0 comments
Labels
app-neovim Issues related to neovim support

Comments

@pokey
Copy link
Member

pokey commented Jul 26, 2024

Today, neovim deploy assumes that any changes to the staging dir come from the head commit. But if there is a race and two commits come in at nearly the same time due to merge queue, we could attribute the changes to the wrong commit

With cursorless-talon it works well because we use a subtree split, but we can't do that here because deploy is not simply a subtree: we actually build something

I'm not sure exactly the best way to do this. One way would be to keep a staging branch of some sort similar to how we do for cursorless-talon, and then re-build and create the staging directory for every commit between last deployed and head. I still think this might result in a race. We should really try to ensure determinism: the commit history on monorepo main completely determines the commit history on deploy branch

@pokey pokey added the app-neovim Issues related to neovim support label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-neovim Issues related to neovim support
Projects
None yet
Development

No branches or pull requests

1 participant