Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3 #183

Closed
10 of 12 tasks
curusarn opened this issue Dec 18, 2022 · 1 comment
Closed
10 of 12 tasks

Release v3 #183

curusarn opened this issue Dec 18, 2022 · 1 comment
Milestone

Comments

@curusarn
Copy link
Owner

curusarn commented Dec 18, 2022

https://github.com/curusarn/resh/tree/reduction

Checklist:

  • BUG: Installation hangs
  • Make restore/backup mechanism more reliable (e.g. what about interrupted and rerun installation)
  • Test v3 installation #188
  • Fix regression: Git repo flag doesn't show up in search anymore - I must have broken providing git repo to search or maybe it is mangled during history processing. 🚨 -> Fixed in: 9958404
  • Update README
    • Install, troubleshoot, copy, tagline, ...
    • Feature showcase
    • Move keybindings from the main page ?
  • Write an announcement
  • 💥 Pre-release -> https://github.com/curusarn/resh/releases/tag/v3.0.0-rc2
  • ⏳ Testing period
  • 🚀 Release

Announcement draft

What's new

Version 3 brings both "under-the-hood" and visible improvements. 🚀
I got rid of many things that made it difficult to move forward with RESH.

Removed features

  • Arrow up/down
  • Shell completions - they might come back later

Improvements

  • Smaller history records
    • Less used disk space, faster loading
    • Smaller memory consumption
  • Better locations for config and data
    • Config location respects $XDG_CONFIG_HOME (default: ~/.config/)
    • Data location respects $XDG_DATA_HOME (default: ~/.local/share/)
    • Shell files and binaries use ~/.resh/
  • Added reshctl doctor command that checks common issues
  • Better logging
    • More complete structured logs from all components
    • Debugging of reported issues based on just logs will be radically easier
  • Removed dependencies
    • setsid and nohup not required
    • Improved portability / simplified installation
  • Update script improvements
    • Much more robust shell config files reloading
    • Seamless migration of records format
    • Seemless migration of config file format
  • Smaller fixes
    • Git URLs normalization in search
    • Improved command deduplication in search
    • Handle hostname changes gracefully
    • Unified way to get datetime
    • Unified way to generate UUID
@curusarn curusarn added this to the v3 milestone Dec 18, 2022
@curusarn
Copy link
Owner Author

curusarn commented Jan 2, 2023

Installation hangs bug only affected make install - i.e. build and install from source used in development.
The bug only manifested itself when Make was configured to use jobserver (-j N option or MAKE_JOBS=N env var).

During installation daemon is killed, then started again and detached from the process.
However, it looks like Make still detects the running process, considers it an "unfinished job" and halts indefinitely.

Running the install target as nested make with disabled parallelism (i.e. -j1) solves the issues.

EDIT: this issue seems to be macOS-specific
EDIT2: the issue is not really macOS-specific - It affects make version 3.81 and it doesn't affect 4.4

@curusarn curusarn pinned this issue Jan 19, 2023
@curusarn curusarn changed the title Release v3 pre-release Release v3 Feb 28, 2023
@curusarn curusarn closed this as completed Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant